Skip to content

fix/text-updated and the barchart fixes - #304

Open
mahmoodcli wants to merge 9 commits into
mainfrom
fix/text-updated
Open

fix/text-updated and the barchart fixes#304
mahmoodcli wants to merge 9 commits into
mainfrom
fix/text-updated

Conversation

@mahmoodcli

@mahmoodcli mahmoodcli commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Description

Updates the KS2 primary performance page by refreshing the scaled score and GPS explanatory text, correcting scaled score chart axes and label positioning, and fixing top performer ordering when displayed values tie. Adds test coverage for the updated chart and ranking behaviour.

Related Trello Ticket

https://trello.com/c/E1Us7jPo

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Tested on [Environment: Dev/Staging/Local]

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have verified accessibility requirements are met

Screenshots (if applicable)

image

@mahmoodcli mahmoodcli added the deploy deploy application label Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

Deployments

Review app is available at these URLs:
https://get-school-improvement-insights-pr-304.test.teacherservices.cloud

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Code Coverage Report: Only Changed Files listed

Package Coverage
Overall Coverage 🟢 70.44%

Minimum allowed coverage is 0%, this run produced 70.44%

@mahmoodcli mahmoodcli changed the title fix/text-updated fix/text-updated and the barchart fixes Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy deploy application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant